PATCH: XGraphicsConfiguration implement font metrics cache

Tom Tromey tromey@redhat.com
Fri Jan 31 23:27:00 GMT 2003


>>>>> "Scott" == Scott Gilbertson <scottg@mantatest.com> writes:

Scott> Index: libjava/ChangeLog
Scott> from  Scott Gilbertson  <scottg@mantatest.com>

It looks like this is a patch on top of an earlier patch.
It didn't apply cleanly to my 3.3 tree.

Could you regenerate it against the 3.3 branch (or the trunk, same
difference) and also fix some style problems too?

It needs a full ChangeLog entry.  I can send you a URL for the GNU
coding standards if you want, or you can just look at other entries.
(The standards also talk about the GNU C style, which is the basis for
our Java style.)

There are numerous minor formatting problems, eg:

Scott> +        if( entry != null )

This should be formatted `if (entry != null)'

Scott> +        {

This should be indented two spaces relative to the `if'.

Scott> +      }
Scott> +      /** Put an entry in the cache, eliminating the oldest entry if
Scott> +       * the cache is at capacity.
Scott> +       */
Scott> +      void put( Font font, XFontMetrics fontMetrics )

There should be a newline after the `}'; the parens need to be fixed,
etc.


Thanks in advance.  I know these things are a pain, especially if you
usual programming style differs from the GNU style.

Tom



More information about the Java-patches mailing list