[RFA] Sparc libjava support update
Andrew Haley
aph@cambridge.redhat.com
Sun Apr 21 04:01:00 GMT 2002
David S. Miller writes:
> From: Andrew Haley <aph@redhat.com>
> Date: Sun, 21 Apr 2002 11:34:10 +0100 (BST)
>
> In fact, can you plese provide an explanatory comment for all this
> weirdness:
>
> I'm finding the signal frame saved regs, and then using
> that to advance the Sparc program counter "in the standard way
> for Sparc" which is "pc = next_pc; next_pc += 4;".
>
> What's not to understand?
>
> I'll add the comments, but I cringe when comments speak out what the C
> code does line by line ala:
>
> /* Add one to c */
> c++;
No, that's not what I'm asking for. The thing that needs commenting is
if (insn == 0x821020d8) \
regp = (struct sig_regs *) _sip; \
else \
regp = (struct sig_regs *) (_sip + 1); \
What is the magic insn? Why does it cause regp to be off by one?
> As all it does is take up valuable screen real-estate :-(
>
> And the comments here shouldn't be a lesson in Sparc or Linux signal
> internals either, I think.
Andrew.
More information about the Java-patches
mailing list