Patch: PR 5942

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Tue Mar 26 12:50:00 GMT 2002


 > From: Tom Tromey <tromey@redhat.com> 
 > 
 >     * parse.y (init_src_parse): Added sanity check.
 > 
 > +  /* Sanity check; we've been bit by this before.  */
 > +  if (sizeof (ctxp->modifier_ctx) / sizeof (tree) != 
 > +      MODIFIER_TK - PUBLIC_TK)

Please consider using ARRAY_SIZE(ctxp->modifier_ctx) (defined in
libiberty.h) instead of an explicit sizeof() / sizeof().

IMHO, ARRAY_SIZE is much more readable.

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			Director of Systems Architecture
ghazi@caip.rutgers.edu		Qwest Global Services



More information about the Java-patches mailing list