Patch: FYI: --help/--version fixlets

Tom Tromey tromey@redhat.com
Mon Mar 25 14:47:00 GMT 2002


I'm checking this in.

This removes an extra "GNU" from some --version output.
It also adds --help and --version to rmiregistry.

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	For PR libgcj/5303:
	* gnu/java/rmi/registry/RegistryImpl.java (main): Recognize --help
	and --version.
	(help): New method.
	(version): Likewise.
	* gnu/gcj/convert/Convert.java (version): Removed extraneous
	"GNU".
	* gnu/java/rmi/rmic/RMIC.java (parseOptions): Removed extraneous
	"GNU".

Index: gnu/gcj/convert/Convert.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/gcj/convert/Convert.java,v
retrieving revision 1.7
diff -u -r1.7 Convert.java
--- gnu/gcj/convert/Convert.java 2002/02/22 23:24:39 1.7
+++ gnu/gcj/convert/Convert.java 2002/03/25 21:57:51
@@ -40,7 +40,7 @@
 
   static void version ()
   {
-    System.out.println("jv-convert (GNU "
+    System.out.println("jv-convert ("
 		       + System.getProperty("java.vm.name")
 		       + ") "
 		       + System.getProperty("java.vm.version"));
Index: gnu/java/rmi/registry/RegistryImpl.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/rmi/registry/RegistryImpl.java,v
retrieving revision 1.2
diff -u -r1.2 RegistryImpl.java
--- gnu/java/rmi/registry/RegistryImpl.java 2002/01/22 22:40:00 1.2
+++ gnu/java/rmi/registry/RegistryImpl.java 2002/03/25 21:57:52
@@ -1,5 +1,5 @@
 /*
-  Copyright (c) 1996, 1997, 1998, 1999 Free Software Foundation, Inc.
+  Copyright (c) 1996, 1997, 1998, 1999, 2002 Free Software Foundation, Inc.
 
 This file is part of GNU Classpath.
 
@@ -103,9 +103,35 @@
 	return (strings);
 }
 
+public static void version() {
+	System.out.println("rmiregistry ("
+			   + System.getProperty("java.vm.name")
+			   + ") "
+			   + System.getProperty("java.vm.version"));
+	System.out.println("Copyright 2002 Free Software Foundation, Inc.");
+	System.out.println("This is free software; see the source for copying conditions.  There is NO");
+	System.out.println("warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.");
+	System.exit(0);
+}
+
+public static void help() {
+	System.out.println(
+"Usage: rmiregistry [OPTION | PORT]\n" +
+"\n" +
+"    --help                Print this help, then exit\n" +
+"    --version             Print version number, then exit\n");
+	System.exit(0);
+}
+
 public static void main(String[] args) {
 	int port = Registry.REGISTRY_PORT;
 	if (args.length > 0) {
+		if (args[0].equals("--version")) {
+			version();
+		}
+		else if (args[0].equals("--help")) {
+			help();
+		}
 		try {
 			port = Integer.parseInt(args[0]);
 		}
Index: gnu/java/rmi/rmic/RMIC.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/rmi/rmic/RMIC.java,v
retrieving revision 1.6
diff -u -r1.6 RMIC.java
--- gnu/java/rmi/rmic/RMIC.java 2002/02/22 23:24:41 1.6
+++ gnu/java/rmi/rmic/RMIC.java 2002/03/25 21:57:52
@@ -939,7 +939,7 @@
 			usage();
 		}
 		else if (arg.equals("-version")) {
-			System.out.println("rmic (GNU "
+			System.out.println("rmic ("
 					   + System.getProperty("java.vm.name")
 					   + ") "
 					   + System.getProperty("java.vm.version"));



More information about the Java-patches mailing list