WIN-32: _Jv_platform_gettimeofday now takes no args, returns jlong

Tom Tromey tromey@redhat.com
Fri Mar 8 14:58:00 GMT 2002


>>>>> "Adam" == Adam Megacz <patches@lists.megacz.com> writes:

Adam>         * posix.cc (_Jv_platform_gettimeofday): Now takes no args,
Adam>         returns jlong.

You didn't update all the callers.  This broke the build.  If you make
changes to platform-dependent code, either build on (an instance of)
that platform or ask someone to try the patch for you.

Note that the review process doesn't always catch bugs.  I try to
think of it as a collaboration.  When I submit a patch that requires
approval, I try to explain my testing process, and what I was not able
to test.  This gives the reviewer more information.

We're pretty lax about certain kinds of bugs.  We make a best effort
not to introduce them.  However, we try to be strict about the build.
Breaking it is unacceptable.

I've checked in a fix for this.

Tom



More information about the Java-patches mailing list