java.lang.Character

[Eric Blake]

Bryce McKinlay wrote:
> 
> >Anyway, this patch looks great to me.  Please do check it in.
> >Can you also check it in on the 3.1 branch?  I think we might as well
> >do that too.
> >

OK, I just committed this on the head and the 3.1 branch.  Someone will
need to go in and regenerate configure and Makefile.in, as I can't get
the libjava version of the autotools to work on cygwin.

> 
> One thing that might be improved is to have the getType() method in
> native code. Currently a lot of the methods in the Java code call
> getType() which then calls the native readChar() - it would reduce the
> number of calls to have getType() native as well?

There is still only one native call, whether getType() is native or in
Java.  I guess you are arguing that as long as we have to go native, we
might as well reduce the Java call stack by one?  But I went ahead and
made getType() native, as you suggested.

> 
> Also could some of the other tables like BLOCKS be done as C arrays also?

What tables are you referring to? I made sure all the tables of
java.lang.Character are C arrays; any tables for other classes will have
to be a future patch.

-- 
This signature intentionally left boring.

Eric Blake             ebb9@email.byu.edu
  BYU student, free software programmer