PLEASE READ THIS IF YOU CAN APPROVE LIBGCJ CHANGES

[Bryce McKinlay]

Adam Megacz wrote:

>Look, I apoligize for shouting, but this is the fifth time I've posted
>this patch. Somebody please either approve it or tell me what I need
>to change in order to get it approved. Hans signed off on it pending
>additional approval by somebody else.
>
>Thanks.
>
>  - a
>
>
>Adam Megacz <patches@lists.megacz.com> writes:
>
>>Boehm> I did look at the patches quickly.  The first one is OK with
>>Boehm> me, but I think one of the other libgcj maintainers should look
>>Boehm> at it, since it affects the default configuration for embedded
>>Boehm> uses.  (Please ignore if they already did.  I'm way behind on
>>Boehm> my mail.)
>>
>>Ok to commit?
>>
>>  - a
>>
>>
>>Adam Megacz <patches@lists.megacz.com> writes:
>>
>>>2002-01-31  Adam Megacz <adam@xwt.org>
>>>
>>>        * gcc/boehm-gc/configure.in: support for win32, saner cross-compile options
>>>
>>>
>>>*** configure.in        Sat Dec 15 23:12:04 2001
>>>--- configure.in        Thu Jan 31 00:30:46 2002
>>>*************** case "$THREADS" in
>>>*** 108,114 ****
>>>        ;;
>>>      esac
>>>      ;;
>>>!  decosf1 | irix | mach | os2 | solaris | win32 | dce | vxworks)
>>>      AC_MSG_ERROR(thread package $THREADS not yet supported)
>>>      ;;
>>>   *)
>>>--- 108,117 ----
>>>        ;;
>>>      esac
>>>      ;;
>>>!  win32)
>>>!     AC_DEFINE(GC_WIN32_THREADS)
>>>!     ;;
>>>!  decosf1 | irix | mach | os2 | solaris | dce | vxworks)
>>>      AC_MSG_ERROR(thread package $THREADS not yet supported)
>>>      ;;
>>>   *)
>>>

This part is fine.

>>>
>>>*************** AC_DEFINE(GC_GCJ_SUPPORT)
>>>*** 226,237 ****
>>>  AC_DEFINE(ATOMIC_UNCOLLECTABLE)
>>>
>>>  dnl This is something of a hack.  When cross-compiling we turn off
>>>! dnl some functionality.  We also enable the "small" configuration.
>>>! dnl These is only correct when targetting an embedded system.  FIXME.
>>>  if test -n "${with_cross_host}"; then
>>>     AC_DEFINE(NO_SIGSET)
>>>-    AC_DEFINE(NO_CLOCK)
>>>-    AC_DEFINE(SMALL_CONFIG)
>>>     AC_DEFINE(NO_DEBUGGING)
>>>  fi
>>>
>>>--- 229,238 ----
>>>  AC_DEFINE(ATOMIC_UNCOLLECTABLE)
>>>
>>>  dnl This is something of a hack.  When cross-compiling we turn off
>>>! dnl some functionality. These is only correct when targetting an
>>>! dnl embedded system.  FIXME.
>>>  if test -n "${with_cross_host}"; then
>>>     AC_DEFINE(NO_SIGSET)
>>>     AC_DEFINE(NO_DEBUGGING)
>>>  fi
>>>EOF
>>>

I'd suggest, instead of doing this, check a variable like 
embedded_target and set it in the embedded looking configurations like 
mipstx39-*-elf*. This way it shouldn't have the potential to break any 
existing embedded targets. With that change the patch is fine.

regards

Bryce.