Patch: FYI: More AWT merging

Bryce McKinlay bryce@waitaki.otago.ac.nz
Thu Jan 17 17:55:00 GMT 2002


Tom Tromey wrote:

>I'm checking this in, another in the endless AWT merge.
>
>This merges MenuComponent, MenuItem, and Button.
>
>
>+/**
>+  * Returns a debugging string for this button.
>+  *
>+  * @return A debugging string for this button.
>+  */
>+protected String
>+paramString()
>+{
>+  return(getClass().getName() + "(label=" + getLabel() + ",actionCommand=" +
>+         getActionCommand() + ")");
>+}
>+
>+} // class Button 
>+
>
The merged paramString methods may be wrong here - I dont think they 
should ever call getClass().getName() or toString(). toString() calls 
paramString (see Component).

getTreeLock() shouldn't be public.

regards

Bryce.
 



More information about the Java-patches mailing list