Final (TCP) socket timeout patch?

Bryce McKinlay bryce@waitaki.otago.ac.nz
Fri Jan 4 16:29:00 GMT 2002


Nic Ferrier wrote:

>Here is my last socket timeout patch (I hope).
>
>Please tell me that you think this is ok. If not I may have a pychotic
>episode.
>

This is fine apart from some minor lingering formatting nits. Please 
check in the patch after fixing them. There is no need to resubmit the 
patch. Thanks!

>+  /** A cached copy of the in stream for reading from the socket.
>+   */
>   private InputStream in;
>

These comments might as well be one-liners, ie the "*/" on the same line.

>
>+    if(in == null)
>+      in = new SocketInputStream();
>
Need a space after "if"...

>+  return(jint) num;
>+#else
>+  throw new java::io::IOException (JvNewStringUTF ("unimplemented"));
>+#endif
>+ }
>+
>
... and "return".

regards

Bryce.




More information about the Java-patches mailing list