some patches for 1.3 compatibility
Bryce McKinlay
bryce@waitaki.otago.ac.nz
Thu Mar 29 19:43:00 GMT 2001
Tony Kimball wrote:
> Porting an app, I found these patches useful. The Win32 stuff is not
> tested at all yet.
Thank you. In order to accept a patch of this size, we will need a copyright assignment to be completed
and filed with the FSF. See: http://gcc.gnu.org/contribute.html
I have a few comments about the patch itself.
> --- PlainSocketImpl.java 2000/12/08 10:28:32 1.8
> +++ PlainSocketImpl.java 2001/03/30 01:45:46
> @@ -35,6 +35,10 @@
> _Jv_SO_SNDBUF_ = SocketOptions.SO_SNDBUF,
> _Jv_SO_RCVBUF_ = SocketOptions.SO_RCVBUF;
>
> + private boolean shutdown_input = false;
> +
> + private boolean shutdown_output = false;
> +
It would conserve a few bytes to use a bitmask here instead of boolean flags.
> --- InputStream.java 2000/03/07 19:55:26 1.3
> +++ InputStream.java 2001/03/30 01:45:47
> @@ -20,10 +20,16 @@
>
> public abstract class InputStream
> {
> + protected boolean isEOF = false;
> +
> public InputStream()
> {
> }
>
> + public void setEOF() {
> + isEOF = true;
> + }
> +
Where does all this EOF stuff come from? It is not present in the J2SE 1.3 documentation from Sun:
http://java.sun.com/j2se/1.3/docs/api/java/io/InputStream.html
Was it added in a newer release than 1.3.0?
Otherwise, this looks fine.
regards
[ bryce ]
More information about the Java-patches
mailing list