libiberty: V3 ABI Java symbol demangling

[Bryce McKinlay]

Daniel Berlin wrote:

> > The changeover to the V3 ABI broke Java symbol demangling in GDB. This
> > patch changes cplus_demangle() to use the V3 ABI demangling code for
> > Java symbols. cplus_demangle_v3 doesn't know how to output symbols in
> > Java-style yet, but C++ style is definitely better than nothing.
> >
> > ok to commit?
>
> Wait just a second.
>
> Why don't you add the approriate code to make JAVA demangling work with
> AUTO_DEMANGLING, rather than add another case?

Java demangling is strictly a change in the style of output (ie
"::" becomes ".", "JArray<>" becomes "[]", etc). Automatic selection of the
demangling style can't really work, since there is no practical way to tell
the difference between a Java symbol and a C++ symbol. GDB needs to (and
does) explicitly tell the demangler that it wants a symbol in Java style.
Currently that results in no demangling, because the demangler attempts to
use the old ABI demangling for a new ABI symbol and fails.

> Won't this break old-abi java demangling?

Java does not support the old ABI.

regards

  [ bryce ]