Old patch for DataInpuStream from Classpath

Bryce McKinlay bryce@albatross.co.nz
Thu Jan 25 14:02:00 GMT 2001


Warren Levy wrote:

> On Thu, 25 Jan 2001, Mark Wielaard wrote:
>
> > The following patch was made last month to the Classpath version of
> > java.io.InputStream but was not applied to the libgcj version.
> > OK to commit?
> >
> > 2000-12-09  Bryce McKinlay  <bryce@albatross.co.nz>
> >
> >     * java/io/DataInputStream.java (readBoolean): Use convertToBoolean().
> ...
>
> Looks fine to me; I've cc'ed Bryce in case he had a reason to not put it
> in libgcj.

I had made an attempt to merge the classpath and libgcj implementations of
DataInputStream, but this turned out to be difficult due to differences in the
classpath and libgcj implementations of RandomAccessFile. That patch was just
to put the convertToBoolean() back in to classpath in order to support other
(native) classes which relied on it and make the build work.

There's probibly no reason why the classpath version can't go into libgcj,
except that its a little more complicated and possibly less efficient. Long
term, the best solution is a cleanup/merge of all the
File/FileDescriptor/RandomAccessFile related stuff... unfortunately this is
made difficult due to the need to write JNI code for classpath, but Brian
agreed that we should create a definitive, merged version in libgcj and worry
about writing the JNI stuff for classpath later. This is a big job
unfortunately, since the socket code may need to be changed as well because it
relies on FileDescriptor. As it stands the libgcj implementation is quite
good, but it has portability issues which need to be thought through...

regards

  [ bryce ]




More information about the Java-patches mailing list