What is the purpose of these two fixincludes?

[David Edelsohn]

On Thu, Jun 6, 2024 at 6:22 AM FX Coudert via Gcc <gcc@gcc.gnu.org> wrote:

> Hi,
>
> > I usually just install with install-no-fixedincludes, but really this
> > should probably be a configure option and default to on.
>
> It would be great if we could measure what fixincludes are still needed,
> on which targets. Could we possibly modify contrib/test_summary to list the
> fixincluded headers? How would people feel about that?
>
> Out of 273 fixes, ~170 are explicitly target-specific. When we look at
> machines involved:
>
>   34 *-*-aix*
>   22 *-*-darwin*
>   15 *-*-solaris2*
>   12 *-*-vxworks*
>   10 *-*-*vms*
>    5 *-hp-hpux11*
>    3 i[34567]86-*-linux*
>    3 *-hp-hpux11.[0-3]*
>    3 *-*-solaris*
>    3 *-*-netbsd*
>
> The question is: out of the remaining ~100, how many trigger on common
> targets, when they are actually useless. Having the information in the test
> summary would be great, I think.
>
> Best,
> FX


The following are the fixes that trigger on my AIX 7.2.5 system that I use
for testing.  AIX 7.2 is still supported.  AIX has a lot of OSF pieces, so
those continue to trigger.  The gcc119 in the compile farm runs AIX 7.3.

Fixing directory /usr/include into /tmp/GCC/gcc/include-fixed
Applying aix_assert               to assert.h
Applying strict_ansi_only         to assert.h
Fixed:  assert.h
Applying aix_complex              to complex.h
Fixed:  complex.h
Applying aix_null                 to curses.h
Fixed:  curses.h
Applying aix_null                 to dbm.h
Fixed:  dbm.h
Applying AAB_aix_fcntl            to fcntl.h
Fixed:  fcntl.h
Applying io_quotes_def            to isode/pepsy.h
Applying machine_name             to libmilter/mfapi.h
Fixed:  libmilter/mfapi.h
Quoted includes in libmilter/mfapi.h
Applying aix_null                 to locale.h
Fixed:  locale.h
Applying sun_malloc               to malloc.h
Applying hpux8_bogus_inlines      to math.h
Applying math_exception           to math.h
Applying rs6000_double            to math.h
Fixed:  math.h
Applying io_quotes_use            to net/bpf.h
Fixed:  net/bpf.h
Applying aix_net_if_arp           to net/if_arp.h
Fixed:  net/if_arp.h
Applying io_quotes_use            to netinet/if_802_5.h
Fixed:  netinet/if_802_5.h
Applying io_quotes_def            to netinet/in.h
Applying ip_missing_semi          to netinet/ip.h
Applying io_quotes_def            to netinet/ip6_opts.h
Applying svr4_undeclared_getrnge  to regexp.h
Applying strict_ansi_only         to setjmp.h
Fixed:  setjmp.h
Applying gnu_types                to stddef.h
Fixed:  stddef.h
Applying aix_stdint_1             to stdint.h
Fixed:  stdint.h
Applying AAB_aix_stdio            to stdio.h
Applying aix_null                 to stdio.h
Applying aix_stdio_inline         to stdio.h
Applying stdio_stdarg_h           to stdio.h
Applying stdio_va_list            to stdio.h
Fixed:  stdio.h
Applying aix_null                 to stdlib.h
Applying aix_stdlib_malloc        to stdlib.h
Applying aix_stdlib_realloc       to stdlib.h
Applying aix_stdlib_calloc        to stdlib.h
Applying aix_stdlib_valloc        to stdlib.h
Applying aix_stdlib_vec_malloc    to stdlib.h
Applying aix_stdlib_vec_calloc    to stdlib.h
Applying gnu_types                to stdlib.h
Fixed:  stdlib.h
Applying aix_null                 to string.h
Applying sysv68_string            to string.h
Fixed:  string.h
Applying io_quotes_def            to sys/aio.h
Applying aix_null                 to sys/dir.h
Fixed:  sys/dir.h
Quoted includes in sys/dir.h
Applying io_quotes_def            to sys/dlpi_aix.h
Applying io_quotes_use            to sys/dlpi_aix.h
Applying io_quotes_def            to sys/fs/kdm_dmi.h
Applying io_quotes_def            to sys/ioctl.h
Applying io_quotes_use            to sys/mtio.h
Applying aix_null                 to sys/param.h
Fixed:  sys/param.h
Quoted includes in sys/param.h
Applying io_quotes_use            to sys/ras.h
Applying aix_volatile             to sys/signal.h
Fixed:  sys/signal.h
Applying io_quotes_def            to sys/stropts.h
Applying aix_null                 to sys/types.h
Applying aix_physadr_t            to sys/types.h
Applying gnu_types                to sys/types.h
Fixed:  sys/types.h
Applying next_wait_union          to sys/wait.h
Fixed:  sys/wait.h
Applying aix_null                 to time.h
Fixed:  time.h
Applying aix_null                 to unistd.h
Fixed:  unistd.h
Applying io_quotes_def            to usersec.h
Applying aix_null                 to wchar.h
Applying stdio_va_list_clients    to wchar.h
Fixed:  wchar.h
Fixing directory /usr/include/X11 into
/tmp/GCC/gcc/include-fixed/root/usr/lpp/X11/include/X11
Applying io_quotes_def            to X11/Xmu/Atoms.h

Laugh or cry.

David