[RFC] MAINTAINERS: require a BZ account field

Arsen Arsenović arsen@aarsen.me
Thu Jul 4 16:22:55 GMT 2024


"Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com> writes:

> On 25/06/2024 20:08, Arsen Arsenović via Gcc wrote:
>> Hi,
>> 
>> Richard Biener <richard.guenther@gmail.com> writes:
>> 
>>> [snip]
>>>> I was also proposing (and would like to re-air that here) enforcing
>>>> that the committer field of each commit is a (valid) @gcc.gnu.org
>>>> email.  This can be configured repo-locally via:
>>>>
>>>>   $ git config committer.email <yourname>@gcc.gnu.org
>>>>
>>>> Git has supported this since 39ab4d0951ba64edcfae7809740715991b44fa6d
>>>> (v2.22.0).
>>>>
>>>> This makes a permanent association of each commit to its authors
>>>> Sourceware account.
>>>
>>> I'd welcome this - care to create a patch for
>>> contrib/gcc-git-customization.sh?
>> 
>> Sure - I've attached a partial patch.  I didn't find the hook which runs
>> on each push to check commits, so the current patch is minimal.  Is that
>> also in the tree?  I could try hacking it to check commits.
>
> This won't work for developers who don't have a gcc account.  Previously it didn't matter what you said here, but now it will mess up any personal tree you have.
>
> +git config "committer.email" "${remote_id}@gcc.gnu.org"

You're right - I will add a prompt before pushing (should that even
happen).
-- 
Arsen Arsenović
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 381 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc/attachments/20240704/8fe8732d/attachment.sig>


More information about the Gcc mailing list