[PATCH v2 2/3] libcpp: add a function to determine UTF-8 validity of a C string
David Malcolm
dmalcolm@redhat.com
Fri Oct 28 12:59:16 GMT 2022
On Thu, 2022-10-27 at 19:16 -0400, Ben Boeckel wrote:
> This simplifies the interface for other UTF-8 validity detections
> when a
> simple "yes" or "no" answer is sufficient.
>
> Signed-off-by: Ben Boeckel <ben.boeckel@kitware.com>
> ---
> libcpp/ChangeLog | 6 ++++++
> libcpp/charset.cc | 18 ++++++++++++++++++
> libcpp/internal.h | 2 ++
> 3 files changed, 26 insertions(+)
>
> diff --git a/libcpp/ChangeLog b/libcpp/ChangeLog
> index 4d707277531..4e2c7900ae2 100644
> --- a/libcpp/ChangeLog
> +++ b/libcpp/ChangeLog
> @@ -1,3 +1,9 @@
> +2022-10-27 Ben Boeckel <ben.boeckel@kitware.com>
> +
> + * include/charset.cc: Add `_cpp_valid_utf8_str` which
> determines
> + whether a C string is valid UTF-8 or not.
> + * include/internal.h: Add prototype for
> `_cpp_valid_utf8_str`.
> +
> 2022-10-27 Ben Boeckel <ben.boeckel@kitware.com>
>
> * include/charset.cc: Reject encodings of codepoints above
> 0x10FFFF.
The patch looks good to me, with the same potential caveat that you
might need to move the ChangeLog entry from the patch "body" to the
leading blurb, to satisfy:
./contrib/gcc-changelog/git_check_commit.py
Thanks
Dave
More information about the Gcc
mailing list