[committed] exec-stack warning for test which wants executable stacks

[Jeff Law]

On 4/25/2022 8:42 AM, Nick Clifton wrote:
> Hi Jeff,
>
>>>> I used -z execstack rather than --no-warn-execstack as the former 
>>>> is recognized by older versions of ld, but the latter is a new option.
>>> Thanks for it.
>> Unfortunately, I should have looked at the other failures that have 
>> popped up over the last week.  Essentially all the nested function 
>> tests are failing on some targets due to the same linker warning.
>>
>> Either pruning or adding  the option to all those tests is going to 
>> be necessary ;(
>
> Sorry for causing you so much hassle.
No worries.  It's a very reasonable warning.  And it's only if you're 
testing with the latest binutils that it causes problems -- which is one 
of the goals of the tester -- to find this stuff when it happens, not 
6-12 months later.


>   If it helps, Alan has already added
> some pruning code to binutils/testsuite/lib/binutils-common.exp in the
> prune_extra_warnings proc...
Yea.  I saw that.  I ultimately decided against pruning as it would be 
useful to know if a test suddenly needs execstack.   That would 
generally be a sign of something gone horribly wrong.  I just (locally) 
added the magic to the rest of the affected tests and I'm testing it now.

jeff