New ThreadSanitizer runtime (v3)

Martin Liška mliska@suse.cz
Mon Nov 22 18:38:17 GMT 2021


On 11/22/21 16:22, Dmitry Vyukov wrote:
> I wanted to give heads up regarding a significant re-design of the
> ThreadSanitizer runtime:
> https://reviews.llvm.org/D112603
> Currently it's submitted:
> https://github.com/llvm/llvm-project/commit/1784fe0532a69ead17793bced060a9bf9d232027

And I noticed the following new warnings:

libsanitizer/tsan/tsan_shadow.h:93:32: warning: enumerated and non-enumerated type in conditional expression [-Wextra]
libsanitizer/tsan/tsan_shadow.h:94:44: warning: enumerated and non-enumerated type in conditional expression [-Wextra]

       *typ = (part_.is_read_ ? kAccessRead : kAccessWrite) |
              (part_.is_atomic_ ? kAccessAtomic : 0) |
              (part_.access_ == kFreeAccess ? kAccessFree : 0);

I think 0 should be replaced with kAccessWrite, am I right? Should I create a pull request for it?

Cheers,
Martin


More information about the Gcc mailing list