broken check: You should edit tm.texi.in rather than tm.texi

[Martin Sebor]

On 11/20/20 6:23 AM, Martin Liška wrote:
> Hello.
> 
> I hit the following issue:
> /bin/sh /home/marxin/Programming/gcc/gcc/../move-if-change tmp-tm.texi 
> tm.texi
> You should edit /home/marxin/Programming/gcc/gcc/doc/tm.texi.in rather 
> than /home/marxin/Programming/gcc/gcc/doc/tm.texi .
> 
> Steps to reproduce:
> 1) modify target.def
> 2) you will see:
> 
> Verify that you have permission to grant a GFDL license for all
> new text in /dev/shm/objdir/gcc/tm.texi, then copy it to 
> /home/marxin/Programming/gcc/gcc/doc/tm.texi.
> 
> I copy and commit the changes.
> 
> 3) I made another modification to target.def
> 
> Now I face the issue as
>      elif test $(srcdir)/doc/tm.texi -nt $(srcdir)/doc/tm.texi.in \
>        && ( test $(srcdir)/doc/tm.texi -nt $(srcdir)/target.def \
> 
> So tm.texi.in is older that tm.texi, but it's fine as both tm.texi.in
> and tm.texi are not modified.
> 
> Ideas how to improve the error message? It took me some time to realize
> that 'touch tm.texi.in' is what I need.

I don't know if it was the same problem but I spent a bunch of time
just last week wrestling with this error before it finally went away.

I never did understand what it was complaining about, or the point
of making us jump through these hoops for updates to the internals
manual when the (arguably far more impactful) changes to GCC source
code or the user-visible manual aren't subject to the same check.
Could we dispense with this altogether?  If not, can we implement
something less obtrusive (e.g., looking up the authors email in
MAINTAINERS first)?

Martin