ChangeLog files - server and client scripts
Jason Merrill
jason@redhat.com
Thu May 21 18:52:37 GMT 2020
Was there a decision somewhere to require ChangeLog entries for all
testcase changes now, as the hook is enforcing? They were optional before.
remote: *** ChangeLog format failed:
remote: ERR: changed file not mentioned in a
ChangeLog:"gcc/testsuite/g++.dg/parse/error33.C"
On Thu, May 21, 2020 at 11:38 AM Rainer Orth <ro@cebitec.uni-bielefeld.de>
wrote:
> Hi Martin,
>
> >> two comments:
> >>
> >> * Can you please avoid the use grey highlighting in that section? Black
> >> script on a grey background is already hard to read for someone with
> >> reasonable vision. I suspect it will be much harder for
> >> vision-impaired people.
> >
> > You are right, I fixed that.
>
> thanks.
>
> >> * In changelog_location, you allow only (among others) "a/b/c/" and
> >> "\ta/b/c/". Please also accept the "a/b/c:" and "\ta/b/c:" forms
> >> here: especially the second seems quite common.
> >
> > Sure, can you please link some git revisions that use the format?
>
> Apart from using it myself ;-), I've seen it several times, but no
> examples off-hand. However, it seems only consistent with the forms
> ending in /ChangeLog where you allow the trailing colon, too.
>
> Rainer
>
> --
>
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University
>
>
More information about the Gcc
mailing list