Wrong GCC PR2020 annotated for "[committed, libgomp,amdgcn] Fix plugin-gcn.c bug"

Thomas Schwinge thomas@codesourcery.com
Thu Jan 23 16:43:00 GMT 2020


Hi!

On 2020-01-23T12:46:24+0000, Andrew Stubbs <ams@codesourcery.com> wrote:
> I've committed this patch to fix a bug in the OpenMP argument parsing.

<https://gcc.gnu.org/g:14e5e74698b98f4cbe398cb989dfa27765cbca6e>.

Why did "the system" decided to annotate <https://gcc.gnu.org/PR2020>?
For obvious reasons, there are "2020" references in this commit, but
nothing with a "PR" or "PR [...]/" prefix.

Thus, some problem in GCC's Git/Bugzilla hooks?


Grüße
 Thomas


> It was using a value instead of a mask to read from the arguments. Since 
> the value in question happens to be zero, the comparison would always 
> return true. I've not observed any bad behaviour from this, but in 
> theory it could read attempt to read any unhandled argument as the 
> thread limit.
>
> Andrew
> Fix libgomp plugin-gcn bug
>
> 2020-01-23  Andrew Stubbs  <ams@codesourcery.com>
>
> 	libgomp/
> 	* plugin/plugin-gcn.c (parse_target_attributes): Use correct mask for
> 	the device id.
>
> diff --git a/libgomp/plugin/plugin-gcn.c b/libgomp/plugin/plugin-gcn.c
> index de470a3dd33..7854c142f05 100644
> --- a/libgomp/plugin/plugin-gcn.c
> +++ b/libgomp/plugin/plugin-gcn.c
> @@ -1228,7 +1228,8 @@ parse_target_attributes (void **input,
>  	  grid_attrs_found = true;
>  	  break;
>  	}
> -      else if ((id & GOMP_TARGET_ARG_DEVICE_ALL) == GOMP_TARGET_ARG_DEVICE_ALL)
> +      else if ((id & GOMP_TARGET_ARG_DEVICE_MASK)
> +	       == GOMP_TARGET_ARG_DEVICE_ALL)
>  	{
>  	  gcn_dims_found = true;
>  	  switch (id & GOMP_TARGET_ARG_ID_MASK)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 658 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc/attachments/20200123/5073089d/attachment.sig>


More information about the Gcc mailing list