[PATCH, v3] wwwdocs: e-mail subject lines for contributions
Michael Matz
matz@suse.de
Mon Feb 3 18:20:00 GMT 2020
Hello,
On Mon, 3 Feb 2020, Richard Earnshaw (lists) wrote:
> Well, I'd review a patch differently depending on whether or not it was
> already committed, a patch requiring review or an RFC looking for more
> general comments, so I *do* think such an email prefix is useful.
As I said: a very good argument must be made; it might be that rfc falls
into the useful-tag category.
> >> 'git am' would strip leading [...] automatically unless
> >> you've configured, or asked git to do otherwise. So that leading part
> >> is not counted for the length calculation.
> >
> > There's still e-mail netiquette which also should be obeyed, or at least
> > not contradicted by git netiquette.
>
> The 50 char limit seems to come from wanting git log --oneline to not wrap in
> an 80 column terminal. Whilst laudable, I'm not sure that such a limit
> doesn't become too restrictive and then lead to hard-to-understand summaries.
In my experience hard-to-understand summaries are more related to people
writing them than to length, IOW, I fear a larger limit like 72 characters
won't help that. And, as Segher put it, we aren't really talking about
limits, only about suggestions, if you _really_ have to mention
that 40-character function name in which you fixed something in your
subject, then yeah, you'll go over the 50 chars. But as recommendation
the 50 chars make more sense than the 72 chars, IMHO.
Ciao,
Michael.
More information about the Gcc
mailing list