C++11 code in the gcc 10 branch
Iain Sandoe
iain@sandoe.co.uk
Thu Dec 31 17:54:40 GMT 2020
FX <fxcoudert@gmail.com> wrote:
>> When are you going to apply your fix that Richard S. approved on the
>> 21st?
>
> When I remember how to set up gcc’s git with write access, and remember
> how the new ChangeLog entries work. The times where I was a regular
> contributor were the CVS and SVN times.
>
> I also wanted to ask approval to commit this diff below, fixing
> aarch64_get_extension_string_for_isa_flags()’s prototype to align it with
> the actual function definition:
>
> diff --git a/gcc/config/aarch64/driver-aarch64.c
> b/gcc/config/aarch64/driver-aarch64.c
> index 8840a2d9486c..d99834c99896 100644
> --- a/gcc/config/aarch64/driver-aarch64.c
> +++ b/gcc/config/aarch64/driver-aarch64.c
> @@ -27,8 +27,7 @@
> #include "tm.h"
>
> /* Defined in common/config/aarch64/aarch64-common.c. */
> -std::string aarch64_get_extension_string_for_isa_flags (unsigned long,
> - unsigned long);
> +std::string aarch64_get_extension_string_for_isa_flags (uint64_t,
> uint64_t);
>
> struct aarch64_arch_extension
> {
>
>
> Although I admit that’s almost trivial (and it breaks build on
> aarch64-darwin), I’d prefer to be sure and ask. Then I’ll commit the two
> patches, if you think that’s OK.
If Richard approves the second patch (and you’re stuck for time) - then
send me the patch(es) as attachments with the commit credits you want, and
I can apply them for you.
(thanks for the fixes)
cheers & happy new year all,
Iain
More information about the Gcc
mailing list