Commit messages and the move to git

Jonathan Wakely jwakely.gcc@gmail.com
Wed Nov 20 08:58:00 GMT 2019


On Tue, 19 Nov 2019 at 23:29, Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>
> On Tue, Nov 19, 2019 at 02:36:21PM -0500, Eric S. Raymond wrote:
> > Jason Merrill <jason@redhat.com>:
> > > Well, I was thinking of also giving some clue of what the commit was
> > > about.  One possibly cut-off line accomplishes that, a simple revision
> > > number not so much.
>
> Sure, but it isn't easy at all to automatically come up with anything
> useful or close to correct.  But if you start the subject line with the
> SVN revision number, it is very useful.
>
> > It's conventional under Git to have comments lead with a summary sentence.
> >
> > I think you're going to find that the value of Subversion revision references
> > fades pretty fast after the conversion. That has been my experience with
> > other conversions.
>
> Bugzilla is filled to the brim with SVN revision numbers.  This won't
> lose relevance any time soon.  Decades of history.
>
> Most of the time after I type "git log" I type "/\<123456\>".  We need
> to keep a way to easily map SVN revision ids to git commits, and

As a aside, I use these aliases often with the current git-svn repo:

$ git help srev
'srev' is aliased to 'svn log --show-commit --oneline -r'
$ git srev 276968
r276968 | aa45db50a03 |         PR c++/91930 - ICE with constrained
inherited default ctor.

$ git help sshow
'sshow' is aliased to '!f(){ git srev ${1#r} | awk -F '|'
'/^r[[:digit:]]/ {if (length($2)) print $2}' | xargs --no-run-if-empty
git show ; }; f'

These won't work once we move to Git though.



More information about the Gcc mailing list