Commit messages and the move to git

Jonathan Wakely jwakely.gcc@gmail.com
Wed Nov 20 08:55:00 GMT 2019


On Tue, 19 Nov 2019 at 23:52, Nicholas Krause wrote:
>
>
>
> On 11/19/19 6:44 PM, Joseph Myers wrote:
> > On Tue, 19 Nov 2019, Segher Boessenkool wrote:
> >
> >> Most of the time after I type "git log" I type "/\<123456\>".  We need
> >> to keep a way to easily map SVN revision ids to git commits, and
> >> something a bit more elegant than the ugly git-svn footers would be nice.
> > Whatever reposurgeon's "write --legacy" yield seems appropriate for making
> > the SVN revision ids readily available in the commit messages.  I don't
> > think the summary line is a good place for that information.
> >
> > I do think "Related to PR NNNNN (description)" or similar is a good
> > summary line to insert where the present summary line is just a ChangeLog
> > date/author line.
> Sorry for pointing this out if it was not obvious but Related to PR NNNNN or
> commit id in the message is fine. You would have to figure out whether the
> git id is more important or the PR for each commit as normally only one
> of these is used.

What git ID though? Not all patches are fixing regressions or bugs
introduced by other patches, and even if they are, figuring out the ID
of the commit that introduced the bug by scraping Bugzilla comments is
not practical. If the existing svn commit log mentions a PR number
then that's easy to use, there's no need to complicate it.



More information about the Gcc mailing list