[gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign

[Bernd Schmidt]

On 11/11/2014 09:30 AM, Eric Botcazou wrote:
>> I just don't like all the as_a/is_a stuff enforced everywhere,
>> it means more typing, more temporaries, more indentation.
>> So, as I view it, instead of the checks being done cheaply (yes, I think
>> the gimple checking as we have right now is very cheap) under the
>> hood by the accessors (gimple_assign_{lhs,rhs1} etc.), those changes
>> put the burden on the developers, who has to check that manually through
>> the as_a/is_a stuff everywhere, more typing and uglier syntax.
>> I just don't see that as a step forward, instead a huge step backwards.
>> But perhaps I'm alone with this.
>
> IMO that's the sort of things some of us were afraid of when the C++ switch
> was being discussed and IIRC we were told this would not happen...

I'm with both of you on this.


Bernd