[PATCH] RE: libcilkrts breaks non-bootstrap build

[Iyer, Balaji V]

> -----Original Message-----
> From: Richard Biener [mailto:richard.guenther@gmail.com]
> Sent: Tuesday, November 5, 2013 7:08 AM
> To: Iyer, Balaji V
> Cc: Tom de Vries; gcc@gcc.gnu.org
> Subject: Re: [PATCH] RE: libcilkrts breaks non-bootstrap build
> 
> On Tue, Nov 5, 2013 at 5:17 AM, Iyer, Balaji V <balaji.v.iyer@intel.com>
> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Tom de Vries [mailto:Tom_deVries@mentor.com]
> >> Sent: Monday, November 4, 2013 2:15 PM
> >> To: gcc@gcc.gnu.org
> >> Cc: Iyer, Balaji V
> >> Subject: libcilkrts breaks non-bootstrap build
> >>
> >> Hi,
> >>
> >> When configuring a gcc build with "--disable-bootstrap --enable-
> >> languages=c" I run into this error:
> >> ...
> >> libtool: compile:  g++
> >> -B/home/vries/gcc_versions/devel/lean-c/install/x86_64-unknown-linux-
> >> gnu/bin/
> >> -B/home/vries/gcc_versions/devel/lean-c/install/x86_64-unknown-linux-
> >> gnu/lib/
> >> -isystem
> >> /home/vries/gcc_versions/devel/lean-c/install/x86_64-unknown-linux-
> >> gnu/include
> >> -isystem
> >> /home/vries/gcc_versions/devel/lean-c/install/x86_64-unknown-linux-
> >> gnu/sys-include
> >> "-DPACKAGE_NAME=\"Cilk Runtime Library\""
> >> -DPACKAGE_TARNAME=\"cilk-runtime-library\" -
> DPACKAGE_VERSION=\"2.0\"
> >> "-DPACKAGE_STRING=\"Cilk Runtime Library 2.0\""
> >> -DPACKAGE_BUGREPORT=\"cilk@intel.com\" -DPACKAGE_URL=\"\"
> >> -DPACKAGE=\"cilk-runtime-library\" -DVERSION=\"2.0\" -
> DSTDC_HEADERS=1
> >> -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -
> >> DHAVE_STRING_H=1
> >> -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -
> >> DHAVE_STDINT_H=1
> >> -DHAVE_UNISTD_H=1 -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -
> >> DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -I. -
> >> I/home/vries/gcc_versions/devel/src/libcilkrts
> >> -I/home/vries/gcc_versions/devel/src/libcilkrts/include
> >> -I/home/vries/gcc_versions/devel/src/libcilkrts/runtime
> >> -I/home/vries/gcc_versions/devel/src/libcilkrts/runtime/config/x86
> >> -DIN_CILK_RUNTIME=1 -D_Cilk_spawn= -D_Cilk_sync= -D_Cilk_for=for -
> >> fcilkplus -g3
> >> -O0 -dH -D_GNU_SOURCE -MT bug.lo -MD -MP -MF .deps/bug.Tpo -c
> >> /home/vries/gcc_versions/devel/src/libcilkrts/runtime/bug.cpp  -fPIC
> >> -DPIC - o .libs/bug.o
> >> g++: error: unrecognized command line option '-fcilkplus'
> >> make[2]: *** [bug.lo] Error 1
> >> make[2]: Leaving directory
> >> `/home/vries/gcc_versions/devel/lean-c/build/x86_64-unknown-linux-
> >> gnu/libcilkrts'
> >> ...
> >>
> >> The error occurs because the compiler doesn't support -fcilkplus.
> >>
> >> Should configure disable libcilkplus when c++ is not enabled?
> >>
> >
> > Is the following patch OK to fix this issue?
> 
> Ok.
> 
> Thanks,
> Richard.
> 

Committed as revision 204396.

Thanks,

Balaji V. Iyer.



> > Thanks,
> >
> > Balaji V. Iyer.
> >
> > Index: configure.ac
> >
> ==========================================================
> =========
> > --- configure.ac        (revision 204381)
> > +++ configure.ac        (working copy)
> > @@ -2061,7 +2061,7 @@
> >  case ,${enable_languages}, in
> >    *,c++,*) ;;
> >    *)
> > -    noconfigdirs="$noconfigdirs target-libitm target-libsanitizer target-
> libvtv"
> > +    noconfigdirs="$noconfigdirs target-libcilkrts target-libitm target-
> libsanitizer target-libvtv"
> >      ;;
> >  esac
> >
> > Index: ChangeLog
> >
> ==========================================================
> =========
> > --- ChangeLog   (revision 204381)
> > +++ ChangeLog   (working copy)
> > @@ -1,3 +1,9 @@
> > +2013-11-04  Balaji V. Iyer  <balaji.v.iyer@intel.com>
> > +
> > +       * configure.ac: Added libcilkrts to noconfig list when C++ is not
> > +       supported.
> > +       * configure: Regenerated.
> > +
> >  2013-11-01  Trevor Saunders  <tsaunders@mozilla.com>
> >
> >  * MAINTAINERS (Write After Approval): Add myself.
> > Index: configure
> >
> ==========================================================
> =========
> > --- configure   (revision 204381)
> > +++ configure   (working copy)
> > @@ -6630,7 +6630,7 @@
> >  case ,${enable_languages}, in
> >    *,c++,*) ;;
> >    *)
> > -    noconfigdirs="$noconfigdirs target-libitm target-libsanitizer target-
> libvtv"
> > +    noconfigdirs="$noconfigdirs target-libcilkrts target-libitm target-
> libsanitizer target-libvtv"
> >      ;;
> >  esac
> >