Should -Wmaybe-uninitialized be included in -Wall?

[Gabriel Dos Reis]

On Tue, Jul 9, 2013 at 4:57 PM, Jeff Law <law@redhat.com> wrote:

> I personally like -Wall -Werror.  While we do run into false positives and
> the set of false positives does change from release to release as a result
> of optimizations, I believe there's been an overall improvement in the
> quality of the codebases that use -Wall -Werror.  I certainly see fewer bugs
> these days blamed on the compiler which are in fact uninitialized variables.

Amen.

If we include a warning in -Wall then it is because we believe it to be
generally useful and likely to uncover common bugs/mistakes.  It is therefore
reasonable for users to issue -Wall -Werror even in application delivery mode.
(I know I systematically turn it on for some of my programs and when
delivering code base to my students.)

In fact, if a warning generates too many false positives or annoying
diagnostics for idiomatic constructs, then it is a good indication that
it not ready for -Wall.

-- Gaby