i386 define_asm_attributes question

[Andrew Pinski]

On Mon, May 7, 2012 at 4:28 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
>  >
>> > Index: config/i386/i386.md
>> > ===================================================================
>> > --- config/i386/i386.md (revision 187257)
>> > +++ config/i386/i386.md (working copy)
>> > @@ -661,7 +661,7 @@
>> >
>> >  ;; Describe a user's asm statement.
>> >  (define_asm_attributes
>> > -  [(set_attr "length" "128")
>> > +  [(set_attr "length" "16")
>> >    (set_attr "type" "multi")])
>> >
>> >  (define_code_iterator plusminus [plus minus])
>>
>> I checked with our people.  The maximum insn length on Intel
>> processor is 15byte.
>
> The idea here was originally to prevent LOOP instruction to get out of bounds.
> ASM statement even if they are single line may be arbitrary long and thus can
> run out of the limits.
> We don't produce length instructions anymore, where did you run into problem
> with this setting?

Also the length on asm is multiplied by the number of "statements" in
the inline-asm so it should work correctly anyways.

Thanks,
Andrew Pinski