Bugzilla shouldn't mangle patches
Jonathan Wakely
jwakely.gcc@gmail.com
Tue Nov 15 12:30:00 GMT 2011
I wanted to download my patch in comment 15 of http://gcc.gnu.org/PR2972#c15
So I clicked on the attachment link, and I get the patch viewer,
showing me a coloured, side-by-side diff. Very pretty, but no use if
I want to download it to apply it to the GCC source.
So I clicked on the "Raw Unified" link above the side-by-side view.
That doesn't give me the original patch, it gives me some mangled
version. The original had these headers:
--- c-family/c.opt.orig 2010-11-10 23:23:15.000000000 +0000
+++ c-family/c.opt 2010-12-03 17:08:06.932923281 +0000
But the text I get from the "Raw Unified" link has this header:
--- c-family/c.opt.orig 2010-11-10 23:23:15.000000000 +0000
+++ c-family/c.opt.orig 2010-12-03 17:08:06.932923281 +0000
Notice how both filenames now have the .orig suffix, which means the
patch won't apply to the GCC source because that file doesn't exist.
Why can't I just download my patch, in the same form I uploaded it?
I uploaded a working patch, why does Bugzilla think I need its help to
improve it?
I can go to the [details] link and copy and paste the patch, but I'm
not sure if that would correctly preserve tabs in the source, and it
shouldn't be necessary anyway.
More information about the Gcc
mailing list