please revert r163815/r163816

Jack Howarth howarth@bromo.med.uc.edu
Sat Sep 4 18:41:00 GMT 2010


On Sat, Sep 04, 2010 at 08:22:24AM -0700, H.J. Lu wrote:
> On Fri, Sep 3, 2010 at 8:53 PM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> > Paolo,
> >   Could you please look over PR45524 and then revert the offending
> > r163815/r163816 that has broken decimal float support for all non-linux
> > targets. That patch is wrong in so many ways, it is hard to know where
> > to start...
> >
> > 1) Moving two sections of code from gcc/configure.ac as template and
> > leaving behind a critical intervening section that then gets placed
> > out of sequence.
> >
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45524#c13
> >
> > 2) Assuming that the subtle differences between the three configure.ac's
> > can be ignored...
> >
> > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45524#c11
> >
> > The author needs to first solve the build issues that caused those hacks
> > to be added before attempting to remove them from the common dfp.m4.
> >                Jack
> >
> 
> Please try:
> 
> http://gcc.gnu.org/bugzilla/attachment.cgi?id=21697
> 
> The real problem is that a hack for make dependency in libdecnumber is
> included in config/dfp.m4 which breaks many targets.

H.J.,
   The third permutation of your patch...

http://gcc.gnu.org/bugzilla/attachment.cgi?id=21698

bootstraps and regression tests fine on x86_64-apple-darwin10.
Thanks.
          Jack

> 
> -- 
> H.J.



More information about the Gcc mailing list