Request for code review - (ZEE patch : Redundant Zero extension elimination)
Ian Lance Taylor
iant@google.com
Thu Sep 24 06:24:00 GMT 2009
Paolo Bonzini <bonzini@gnu.org> writes:
> On 09/24/2009 08:14 AM, Ian Lance Taylor wrote:
>> I don't agree with this. If we want this code to be x86_64 specific,
>> then it should be done by having the i386 backend add the pass to the
>> pass manager, much as plugins can add a pass. Adding stuff to
>> md-reorg is a step backward.
>
> That's true. However, time is ticking for 4.5 and this could be a
> decent interim solution while for 4.6 the appropriate hooks could be
> added.
We already have the hooks, they have just been stuck in plugin.c when
they should really be in the generic backend. See register_pass.
(Sigh, every time I looked at this I said "the pass control has to be
generic" but it still wound up in plugin.c.)
Ian
More information about the Gcc
mailing list