WTF?

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Wed Nov 25 20:33:00 GMT 2009


From: "Richard Guenther" <rguenther@suse.de>
 
> The change certainly didn't fall under the obvious rule because of its
> size.  One might argue that 'and similar stuff' covers coding-style
> changes, but here again I'd fear of a certain kind of people going
> wild and follow the coding-style by word rather than existing
> practice in GCC or even the code around their changes.  So, I would
> say even obvious patches should be posted for review with the
> usual (but not documented) "will checkin tomorrow if there are no
> complaints" style disclaimer.

Given its size, I agree that would have been the sensible thing to do.




More information about the Gcc mailing list