PR37363: PR36090 and PR36182 all over again

Paolo Bonzini bonzini@gnu.org
Sat Sep 6 09:13:00 GMT 2008


> I'm not sure about this bit. Couldn't [snip cse.c code]
> simply be replaced by:
> 
>       /* We can't simplify extension ops unless we know the
> 	 original mode.  */
>       if ((code == ZERO_EXTEND || code == SIGN_EXTEND)
> 	  && mode_arg0 == VOIDmode)
> 	break;
> 
>       new = simplify_unary_operation (code, mode,
> 				      const_arg0 ? const_arg0 : folded_arg0,
> 				      mode_arg0);
> ?
> 
> (Sorry if I'm repeating earlier discussion here.)

I think so -- I was just trying to resemble the existing code as much as
possible (stage3), but it's probably better to clean up instead.  What
do you thing about the simplify-rtx.c part instead?

Paolo
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pr37363.patch
URL: <https://gcc.gnu.org/pipermail/gcc/attachments/20080906/66dbd80b/attachment.ksh>


More information about the Gcc mailing list