dg-skip-if was Re: gcc 4.3.0 i386 default question

[Joel Sherrill]

Joseph S. Myers wrote:
> On Wed, 12 Mar 2008, David Edelsohn wrote:
>
>   
>>>>>>> Joel Sherrill writes:
>>>>>>>               
>> Joel> FAIL: gcc.target/powerpc/405-mullhw-1.c scan-assembler mullhw
>>
>> Joel> Are those things which would be expected to fail on a vanilla
>> Joel> 603e target without networking or disk?
>>
>> Joel> Is this another category of tests to avoid somehow?
>>
>>       405-mullhw-1.c is invoked with -mcpu=405 and directly scans the
>> assembly language output -- does not try to create an object file or run
>> an executable.  If that fails, you should check if the RTEMS configuration
>> somehow is inhibiting generation of the mullhwX instruction and
>> TARGET_MULHW flag.
>>     
>
> Also, if you use a multilib option in testing, that option goes on the
> command line *after* the options specified in dg-options.  The tests may
> need to use dg-skip-if to skip them if any CPU option other than the one
> in the test is explicitly specified (so it would be tested if no explicit
> -mcpu option is used, or if -mcpu=405 is the multilib option being
> tested).
>   

Are you thinking of something roughly like this?

/* { dg-skip-if "" { { !-mcpu=405 } } { "*" } { "" } } */

Would that work if somehow two -mcpu flags were on the line?

This is the command line in question:

Executing on host: /home/joel/work-gnat/svn/b-gcc1-powerpc/gcc/xgcc 
-B/home/joel/work-gnat/svn/b-gcc1-powerpc/gcc/ 
/home/joel/work-gnat/svn/gcc/gcc/testsuite/gcc.target/powerpc/405-nmaclhw-2.c 
-O2 -mcpu=405 -DSTACK_SIZE=2048 -fno-show-column -S 
-B/home/joel/work-gnat/svn/bsp-install/powerpc-rtems4.9/psim/lib/ -specs 
bsp_specs -qrtems -mcpu=603e -o 405-nmaclhw-2.s (timeout = 300)

FWIW This seems pretty tedious. My grep didn't turn up that
many under gcc.target and I know I have more failures of this
type than I saw uses of dg-skip-if. If the above is what you think
is right, I can take the exact CPU option tested and then make the
test only valid if that CPU option is used. OK?

--joel

> --
> Joseph S. Myers
> joseph@codesourcery.com
>   


-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
   Support Available             (256) 722-9985