[PATCH] BIT_FIELD_REF_UNSIGNED considered harmful

[Diego Novillo]

On 03/05/08 07:18, Richard Guenther wrote:

> Comments?

Makes sense to me.

> + 	      if (INTEGRAL_TYPE_P (TREE_TYPE (t))
> + 		  && (TYPE_PRECISION (TREE_TYPE (t))
> + 		      != TREE_INT_CST_LOW (TREE_OPERAND (t, 1))))
> + 		{
> + 		  error ("integral result type precision does not match "
> + 			 "field size of BIT_FIELD_REF");
> + 		  return t;
> + 		}
> + 	      if (!INTEGRAL_TYPE_P (TREE_TYPE (t))

'else if' here?



Diego.