Creating a patch ready for gcc-patches list

[Brian Sidebotham]

Hi,

Sorry, wasted your time already!! Thanks to Manuel for the information too.

I will re-patch, compile and run the testsuite. Sorry to waste your time 
with my first mail!

Best Regards,

Brian Sidebotham.

Jan-Benedict Glaw wrote:
> On Wed, 2007-06-06 10:15:41 -0700, Brian Sidebotham <micros@valvers.com> wrote:
>> --- ./gcc/value-prof.c	Mon Jun  4 17:27:14 2007
>> +++ ./gcc/value-prof.c	Wed Jun  6 10:13:20 2007
>>
>> @@ -883,15 +883,19 @@ tree_mod_subtract (tree stmt, tree opera
>>    e12 = split_block (bb, bb1end);
>>    bb2 = e12->dest;
>>    bb2->count = all - count1;
>> -
>> +
>>    if (ncounts)	/* Assumed to be 0 or 1.  */
>>      {
>>        e23 = split_block (bb2, bb2end);
>>        bb3 = e23->dest;
>>        bb3->count = all - count1 - count2;
>> +      e34 = split_block (bb3 : bb2, bb3end);
>                            `---------'
> 
> First of all, you should compile GCC with your patch applied, and then
> run the testsuite. No new regressions should occur (or you should have
> a good reason for them!)
> 
>> +    }
>> +  else
>> +    {
>> +      e34 = split_block (bb2, bb3end);
>>      }
>>
>> -  e34 = split_block (ncounts ? bb3 : bb2, bb3end);
>>    bb4 = e34->dest;
>>    bb4->count = all;
> 
> However, this won't even compile, so please redo it, compile it, test
> it with the regression suite and submit it with a ChangeLog entry.
> (Just plain text, don't prepare it as a patch to the ChangeLog file!)
> 
> MfG, JBG
>