Creating a patch ready for gcc-patches list

Brian Sidebotham micros@valvers.com
Wed Jun 6 09:15:00 GMT 2007


Hi,

I am building a cross-compiler for arm, which builds "okay", but the 
output is very noisy whilst compiling gcc. I'd like to sort some of it 
out and submit some patches, but I've not done any patches for gcc 
before so I don't want to create a lot of noise on the gcc-patches list 
by posting up patches that are not considered correctly formatted, etc.

At the end of this message is a patch to remove a 'variable might be 
used uninitialised' warning which is thrown up whilst bootstrapping gcc.

Is this patch okay to submit to the gcc-patches list?

I haven't touched the ChangeLog, should I fill it in?

Best Regards,

Brian Sidebotham.

--- ./gcc/value-prof.c	Mon Jun  4 17:27:14 2007
+++ ./gcc/value-prof.c	Wed Jun  6 10:13:20 2007

@@ -883,15 +883,19 @@ tree_mod_subtract (tree stmt, tree opera
    e12 = split_block (bb, bb1end);
    bb2 = e12->dest;
    bb2->count = all - count1;
-
+
    if (ncounts)	/* Assumed to be 0 or 1.  */
      {
        e23 = split_block (bb2, bb2end);
        bb3 = e23->dest;
        bb3->count = all - count1 - count2;
+      e34 = split_block (bb3 : bb2, bb3end);
+    }
+  else
+    {
+      e34 = split_block (bb2, bb3end);
      }

-  e34 = split_block (ncounts ? bb3 : bb2, bb3end);
    bb4 = e34->dest;
    bb4->count = all;



More information about the Gcc mailing list