[PATCH] Re: conversion warnings in c++

Eric Christopher echristo@apple.com
Sat Jan 14 01:14:00 GMT 2006


> | OK?
>
> yes.
>
> | Did you want me to add this as a testcase?
>
> yes -- so that we don't regress.

Ok. apparently I tested in the wrong directory and we already have a  
few testcases that test whether we're emitting warnings. I've cleaned  
up the testsuite (and added a quick patch to cvt.c to add another  
check on OPT_Wconversion), but I'll ask for approval again, because  
it's quite a few changes.

So, this ok or would you like me to leave some of the warnings there?  
None of them are pedwarns so I'm assuming (based on a quick look  
through the standard) that they aren't necessary and can be  
conditionalized, but I wanted to double check.

-eric

2006-01-13  Eric Christopher  <echristo@apple.com>

         * call.c (convert_like_real): When issuing conversion
         warnings, depend on OPT_Wconversion.
         * cvt.c (build_expr_type_conversion): Ditto.

2006-01-13  Eric Christopher  <echristo@apple.com>

	* g++.old-deja/g++.warn/impint.C: Add -Wconversion.
	* g++.old-deja/g++.warn/impint2.C: Ditto.
	* g++.old-deja/g++.other/null1.C: Ditto.
	* g++.dg/warn/conv2.C: Ditto.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: warnings.diff.txt
URL: <https://gcc.gnu.org/pipermail/gcc/attachments/20060114/108ce55d/attachment.txt>


More information about the Gcc mailing list