Invalid gen_rtx_INSN_LIST usage?

[Ian Lance Taylor]

Marcin Dalecki <martin@dalecki.de> writes:

> > An INSN_LIST which goes into the REG_NOTES field must use a register
> > note such as REG_DEP_TRUE in the mode field.  But merged_insns does
> > not go into the REG_NOTES field.  It is only used within the function
> > try_merge_delay_insns.  Look at the loop at the end of the insns to
> > see how the mode is tested.  The value of SImode is indeed arbitrary.
> > It can be anything distinct from VOIDmode.
> 
> Thank your for explaining. However in this case just reusing the
> following
> enumeration value:
> 
> REG_SAVE_NOTE
> 
> seems to be more pleasant?

Speaking personally, I don't agree.  I think that is precisely as
confusing as the current code.

I think it would be more pleasant to define an enum in reorg.c with
meaningful names, and use that.

Ian