tree ssa and type issues

[Gabriel Dos Reis]

Daniel Berlin <dberlin@dberlin.org> writes:

| On Sat, 2005-05-21 at 18:55 +0200, Andreas Jaeger wrote:
| > Gabriel Dos Reis <gdr@integrable-solutions.net> writes:
| > 
| > > Hi again,
| > >
| > > I just hit this one from tree-ssa-into.c:rewrite_into_ssa()
| > >
| > >   /* Initialize dominance frontier.  */
| > >   dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bitmap *));
| > >                                                        ^^^^^^^^
| > >                                                                 
| > > If the sizeof operand really supposed to be "bitmap*" and not "bitmap"?
| > 
| > This indeed looks wrong - and could lead to real memory corruption
| > :-(.  If this is wrong, he should be changed on the 4.0 branch as
| > well,
| 
| It's wrong, but it couldn't lead to actual memory corruption, since
| sizeof (bitmap) == sizeof (bitmap *), since both are pointers.

Aha.  This the second time, I'm hitting something like this.  The
first one was with libiberty/argv.c:dupargv() a month ago.

-- Gaby