gcc-4.0-20051124-4.0-20051201.diff.bz2 is TERRIBLE!!!

Paolo Bonzini paolo.bonzini@lu.unisi.ch
Mon Dec 5 08:31:00 GMT 2005


J.C. wrote:
> *** gcc-4.0-20051124/gcc/config/i386/i386.c     Mon Nov  7 18:55:03 2005
> --- gcc-4.0-20051201/gcc/config/i386/i386.c     Thu Dec  1 01:53:01 2005
> 
> ! #if defined(HAVE_GAS_HIDDEN) && defined(SUPPORTS_ONE_ONLY)
> 
> ! #if defined(HAVE_GAS_HIDDEN) && (SUPPORTS_ONE_ONLY - 0)
> 
> Why did he remove the 'defined' and put the unreadable '0'?

Because it is possible that SUPPORTS_ONE_ONLY is defined to 0, in which 
case the older code was wrong.

Paolo



More information about the Gcc mailing list