attribute data structure rewrite
Joseph S. Myers
jsm@polyomino.org.uk
Fri Sep 24 01:30:00 GMT 2004
On Thu, 23 Sep 2004, Andrew Pinski wrote:
> Shouldn't name be redefined as char* as you don't really need a full
> IDENTIFIER_NODE? Yes I know that correctly it is not but I would suspect
> that it would give a good speedup as you don't need to allocate as many
> trees as before.
The IDENTIFIER_NODEs would probably already have been allocated in the
course of parsing. Indeed plain strings would probably be better
datastructures - and the cleanup suggested in the comment above
is_attribute_p, keeping the lists in canonical form, might make sense too
- but better to separate such changes into separate patches from the
minimal patch that changes the datastructure to the form indicated.
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
http://www.srcf.ucam.org/~jsm28/gcc/#c90status - status of C90 for GCC 4.0
jsm@polyomino.org.uk (personal mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)
More information about the Gcc
mailing list