fixing vs WARN_CFLAGS vs cross builds

[Nathanael Nerode]

>Yes.  BUILD_CC is 3.2.3, and does not support these:
>
>cc1: unrecognized option `-Wno-variadic-macros'
>cc1: unrecognized option `-Wold-style-definition'
>
>> It may be reasonable to remove the WARN_CFLAGS setting in the fixinc.sh 
>> rule.  We don't use WARN_CFLAGS anyplace else where we use CC_FOR_BUILD. 
>>   This can work in stage2 etc builds, but this is probably not important 
>> enough to worry about.
>> 
>> It would be nice to have a proper bug report though.
>
>I was still trying to figure out what was supposed to happen from a
>theoretical standpoint.  
WARN_CFLAGS should be tested for compatibility with CC (which is basically
what happens on mainline ATM).

It should not be used with CC_FOR_BUILD, which could be different in any
compilation, since the user can specify it as a command-line option to 'make'.

>I have a patch which tests for build!=host and disables WARN_CFLAGS,
>but should fixinc *ever* be built with WARN_CFLAGS?
No, it shouldn't.

-- 
Make sure your vote will count.
http://www.verifiedvoting.org/