The structure of this looks good to me. Some of the assembly, and some of the comments on the assembly, look weird, but I am not a PPC expert - please get a PPC backend maintainer to review them. zw