Bugs in MIPS FUNCTION_ARG_REGNO_P ?

Jim Wilson wilson@specifixinc.com
Wed Mar 3 08:15:00 GMT 2004


On Tue, 2004-03-02 at 23:01, Eric Christopher wrote:
> > 	&& ((N) % FP_INC == 0) && mips_abi != ABI_O64))		\

I see that the introduction of FP_INC made the TARGET_FLOAT64 check
unnecessary.

So the problem is only that excluding ABI_O64 does not make sense here.

The patch is here:
   http://gcc.gnu.org/ml/gcc-patches/2002-04/msg01325.html
Unfortunately, this fails to give any justification for the change, so
there is no easy way to tell why it was checked in now.

I suggest reverting it, waiting to see what breaks, and then properly
documenting the problem that the patch supposedly fixes.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com



More information about the Gcc mailing list