Regressions on mainline\

[Mark Mitchell]

Zack Weinberg wrote:

>Steven Bosscher <stevenb@suse.de> writes:
>
>  
>
>>On Tuesday 22 June 2004 00:32, Andrew Pinski wrote:
>>    
>>
>>>gcov-1.C is failing for mainly because the profiling stuff is not working
>>>right on the mainline  after tree-ssa was merged in, Jan is working on
>>>this.
>>>      
>>>
>>There are also patches pending for profiling stuff, perhaps they help
>>(and perhaps not...).  Unfortunately they've been ignored four times now :-(
>>http://gcc.gnu.org/ml/gcc-patches/2004-06/msg01674.html
>>    
>>
>
>This is a beautiful example of patches that are not getting reviewed
>mainly because no one who can officially review them feels qualified
>to do so.  I'd be willing to sign off on a review done by the author
>of the profiling code, but I'm not sure who that is.
>
I approved the last two patches offline today, in turns out; I didn't 
realize those were the same ones.  The first one caused me to scratch my 
head harder, so I have not tried to review it yet.

However, I don't have any evidence that these patches fix the 
regressions; we shall see, I suppose.

-- 
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com