bootstrap broken on mainline for targets not using DFA
Vladimir Makarov
vmakarov@redhat.com
Tue Jun 8 20:25:00 GMT 2004
Bernardo Innocenti wrote:
> Mostafa Hagog wrote:
>
>> ChangeLog
>> 2004-05-23 Ayal Zaks <zaks@il.ibm.com>
>> Mostafa Hagog <mustafa@il.ibm.com>
>>
>> * Makefile.in (modulo-sched.o, ddg.o): New.
>> * ddg.h, ddg.c, modulo-sched.c: New files.
>> [...]
>
>
>
> This patch breaks bootstap on the few remaining backends that
> don't yet use the DFA scheduler, notably m68k:
It will happen for all ports not having a pipeline description (DFA or
old one).
>
> stage1/xgcc -Bstage1/
> -B/home/bernie/src/gcc-HEAD-install/m68k-unknown-linux-gnu/bin/ -c
> -g -O2 -DIN_GCC -W -Wall -Wwrite-strings -Wstrict-prototypes
> -Wmissing-prototypes -pedantic -Wno-long-long -Wno-variadic-macros
> -Wold-style-definition -Werror -fno-common -DHAVE_CONFIG_H -I. -I.
> -I../../gcc-HEAD/gcc -I../../gcc-HEAD/gcc/.
> -I../../gcc-HEAD/gcc/../include -I../../gcc-HEAD/gcc/../libcpp/include
> -I../../gcc-HEAD/gcc/../libbanshee/libcompat
> -I../../gcc-HEAD/gcc/../libbanshee
> -I../../gcc-HEAD/gcc/../libbanshee/points-to
> ../../gcc-HEAD/gcc/modulo-sched.c -o modulo-sched.o
> ../../gcc-HEAD/gcc/modulo-sched.c: In function `advance_one_cycle':
> ../../gcc-HEAD/gcc/modulo-sched.c:1988: warning: implicit declaration
> of function 'state_transition'
> ../../gcc-HEAD/gcc/modulo-sched.c: In function `ps_has_conflicts':
> ../../gcc-HEAD/gcc/modulo-sched.c:2011: warning: implicit declaration
> of function 'state_reset'
> ../../gcc-HEAD/gcc/modulo-sched.c:2030: warning: implicit declaration
> of function 'state_dead_lock_p'
> make[3]: *** [modulo-sched.o] Error 1
>
>
> This only happens during bootstraps (-Werror). Nothing from
> modulo-sched.o gets linked into cc1 because the part of invocation of
> sms_scedule() in passes.c is protected by "#ifdef INSN_SCHEDULE".
>
> This patch fixed the problem for me. OK for mainline?
>
>
> 2004-06-08 Bernardo Innocenti <bernie@develer.com>
>
> * modulo-sched.c: Compile only when INSN_SCHEDULING is
> defined.
>
Yes, that is ok. Please go ahead and commit the patch. Thanks for the
patch.
Vlad
More information about the Gcc
mailing list