wrong-code regressions review

[Andrew Pinski]

On Dec 15, 2004, at 8:12 AM, Giovanni Bajo wrote:

> Bradley Lucier <lucier@math.purdue.edu> wrote:
>
>> 18548 is a regression (and it's not target specific, it happens on
>> sparc-solaris, x86-linux, and ppc-darwin), but it's very hard to 
>> figure
>> out what is causing the current problem.  There were two previous
>> wrong-code regressions on this code base that have been fixed by
>> unrelated patches, so I don't know if fixing 18548 will just bring
>> other problems to the surface.
>
> 34MB of preprocessed files is really too much. If you are really 
> interested
> in having this fixed (instead of waiting it to be caught and fixed 
> through a
> different testcase/language), you could for instance start by 
> analyzing the
> assembly code to find out the miscompilation at assembly level. If you 
> spot
> that, you can start reducing it even without begin able to run the file
> (just compiling it and looking at the assembly). When the testcase is 
> small,
> it's easy to reconstruct something around it to make it runnable.

And I would try again since there was a fix recently with respect with
computed gotos.

Thanks,
Andrew Pinski