binds_local question

[Mike Stump]

On Aug 30, 2004, at 5:33 PM, Daniel Jacobowitz wrote:
> A variable with specified visibility should be "local" whether or not
> it's defined in this translation unit - that's most of the point.

Ok, then Mark got this slightly wrong?!

*** ./config/darwin.c.~1~       Sat Aug 21 23:36:18 2004
--- ./config/darwin.c   Mon Aug 30 18:29:43 2004
*************** name_needs_quotes (const char *name)
*** 141,149 ****
   static int
   machopic_symbol_defined_p (rtx sym_ref)
   {
!   return ((SYMBOL_REF_FLAGS (sym_ref) & MACHO_SYMBOL_FLAG_DEFINED)
!         /* Local symbols must always be defined.  */
!         || SYMBOL_REF_LOCAL_P (sym_ref));
   }

   /* This module assumes that (const (symbol_ref "foo")) is a legal pic
--- 141,148 ----
   static int
   machopic_symbol_defined_p (rtx sym_ref)
   {
!   /* APPLE LOCAL machopic_symbol_defined_p bugfix */
!   return (SYMBOL_REF_FLAGS (sym_ref) & MACHO_SYMBOL_FLAG_DEFINED);
   }

   /* This module assumes that (const (symbol_ref "foo")) is a legal pic


:-(  Mark, was there some other spelling you liked/wanted/needed?