What's the purpose of struct elt_loc_list's canon_loc field?

Jan Hubicka jh@suse.cz
Thu Apr 8 21:05:00 GMT 2004


> > Jakub Jelinek wrote:
> > >Either these 5 lines should be yanked, or canon_x should be actually
> > >used somewhere (I'm not sure if canon_true_dependence needs also x
> > >canonicalized or not).
> > 
> > canon_true_dependence has a canon_rtx (x_addr) call, so it does not need 
> > x canonicalized.
> > 
> > I don't see any use for the 5 lines of code either.
> 
> The use was supposed to prevent quadratic amount of temporaries comming
> from canon_true_dependencies  (when you pass uncanonicalized argument
> you always allocate memory for canonical copy).  Perhaps I messed
> something up, I've to check in more detail but I am traveling right now,
> so earliest I can do is after 14th.

Hmm, it is obviously messed up.  I wrote the code storing cannon_loc
before I jumped into using canon_true_dependence and then somehow forgot
about the fact that it is used only in one place while elliminating it.
Thanks for noticing that!

Honza
> 
> Honza
> > -- 
> > Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com
> > 



More information about the Gcc mailing list